-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[Bugfix] Fix the issue where reasoning_content is None when Thinkng is enabled and tool_choice is set to 'required'.
#20662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix the issue where reasoning_content is None when Thinkng is enabled and tool_choice is set to 'required'.
#20662
Conversation
…ing is enabled and `tool_choice` is set to `'required'`. Signed-off-by: chaunceyjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chaunceyjiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a bug in the OpenAI API entrypoint that caused the reasoning_content field to be missing under specific conditions involving enabled 'Thinking' and required tool choices. My changes ensure that this crucial debugging and transparency information is always present when expected, and I've added a test to confirm the fix.
Highlights
- Bug Fix: I've addressed an issue where the
reasoning_contentfield in theChatMessageobject wasNonewhenThinkingwas enabled andtool_choicewas set to'required'. - Core Logic Update: I've updated the
chat_completion_full_generatorto ensure thatreasoning_contentis correctly passed to theChatMessageconstructor when generating tool call messages. - Test Coverage: I've added new assertions to the
test_function_tool_usetest case to verify thatreasoning_contentis properly populated (notNoneor empty) whenenable_thinkingis active.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR addresses a bug where reasoning_content was None when Thinking is enabled and tool_choice is set to 'required'. The changes include adding reasoning_content to the ChatMessage object and adding a test case to verify the fix. A suggestion to improve the streaming test case and a potential improvement to the ChatMessage initialization are provided.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
…ng is enabled and `tool_choice` is set to `'required'`. (vllm-project#20662) Signed-off-by: chaunceyjiang <[email protected]>
…ng is enabled and `tool_choice` is set to `'required'`. (vllm-project#20662) Signed-off-by: chaunceyjiang <[email protected]>
…ng is enabled and `tool_choice` is set to `'required'`. (vllm-project#20662) Signed-off-by: chaunceyjiang <[email protected]>
…ng is enabled and `tool_choice` is set to `'required'`. (vllm-project#20662) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…ng is enabled and `tool_choice` is set to `'required'`. (vllm-project#20662) Signed-off-by: chaunceyjiang <[email protected]>
…ng is enabled and `tool_choice` is set to `'required'`. (vllm-project#20662) Signed-off-by: chaunceyjiang <[email protected]>
FIX #20663
Test Result
Before:
After