-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Remove Qwen Omni workaround that's no longer necessary #21057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Qwen Omni workaround that's no longer necessary #21057
Conversation
Signed-off-by: Harry Mellor <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a workaround for Qwen Omni models, which is no longer necessary with recent versions of the transformers library. The change is a simple deletion of the special-casing logic, which improves code clarity and maintainability. The change is correct and beneficial, and I did not find any issues of high or critical severity.
…21057) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: x22x22 <[email protected]>
…21057) Signed-off-by: Harry Mellor <[email protected]>
…21057) Signed-off-by: Harry Mellor <[email protected]>
…21057) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…21057) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…21057) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…21057) Signed-off-by: Harry Mellor <[email protected]>
This PR removes a workaround for Qwen Omni models which is no longer necessary on newer Transformers versions.
There have been several Transformers releases since huggingface/transformers#37517 (the condition for removing this workaround) was merged and vLLM is currently on the latest version of Transformers.