Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Jul 16, 2025

This PR removes a workaround for Qwen Omni models which is no longer necessary on newer Transformers versions.

There have been several Transformers releases since huggingface/transformers#37517 (the condition for removing this workaround) was merged and vLLM is currently on the latest version of Transformers.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a workaround for Qwen Omni models, which is no longer necessary with recent versions of the transformers library. The change is a simple deletion of the special-casing logic, which improves code clarity and maintainability. The change is correct and beneficial, and I did not find any issues of high or critical severity.

@mergify mergify bot added the qwen Related to Qwen models label Jul 16, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 16, 2025 13:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 16, 2025
@DarkLight1337 DarkLight1337 merged commit a931b4c into vllm-project:main Jul 16, 2025
63 of 65 checks passed
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 27, 2025
@hmellor hmellor deleted the remove-old-workaround branch September 29, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants