Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jul 21, 2025

Signed-off-by: Huy Do [email protected]## Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

huydhn and others added 20 commits July 8, 2025 16:40
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Jul 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates PyTorch to version 2.8.0 and adjusts related dependencies and configurations accordingly. The changes appear consistent with this goal across various files, including Dockerfiles, CMakeLists, and requirements files.

I've identified a couple of temporary/debugging code snippets that should be removed before this work-in-progress PR is finalized for merging. These are located in a test script and the main Dockerfile.

Comment on lines +21 to +25
# TESTING, TO BE REMOVED
VLLM_TEST_USE_PRECOMPILED_NIGHTLY_WHEEL=1 VLLM_USE_PRECOMPILED=1 pip3 install -vvv -e . \
--extra-index-url https://download.pytorch.org/whl/test/cu128

pip3 install nvidia-cudnn-cu12==9.5.1.17 --force-reinstall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes are marked as temporary for testing and should be removed. Merging this would introduce test-specific logic into a test script that should reflect the final installation process. Please revert these changes to the original pip3 install command.

Suggested change
# TESTING, TO BE REMOVED
VLLM_TEST_USE_PRECOMPILED_NIGHTLY_WHEEL=1 VLLM_USE_PRECOMPILED=1 pip3 install -vvv -e . \
--extra-index-url https://download.pytorch.org/whl/test/cu128
pip3 install nvidia-cudnn-cu12==9.5.1.17 --force-reinstall
VLLM_TEST_USE_PRECOMPILED_NIGHTLY_WHEEL=1 VLLM_USE_PRECOMPILED=1 pip3 install -vvv -e .

Comment on lines +385 to +386
# DEBUG
python3 -m xformers.info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The DEBUG comment and the python3 -m xformers.info command appear to be for debugging purposes. Please remove them before merging to keep the Dockerfile clean.

@mergify
Copy link

mergify bot commented Jul 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @atalman.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 24, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Oct 23, 2025
@DarkLight1337
Copy link
Member

Closing as superseded by #20358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase rocm Related to AMD ROCm stale Over 90 days of inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants