Skip to content

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jul 30, 2025

@mgoin mgoin added the ci-failure Issue about an unexpected test failure in CI label Jul 30, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin changed the title Fix CI OOM for test_shared_storage_connector_hashes [CI Bugfix] Fix CI OOM for test_shared_storage_connector_hashes Jul 30, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a recurring out-of-memory (OOM) error in the test_shared_storage_connector_hashes CI test. The changes introduce gpu_memory_utilization=0.4 and enforce_eager=True to the EngineArgs for this specific test. This is a sound approach to reduce memory consumption in a resource-constrained CI environment, as it limits the KV cache size and disables CUDA graphs which can be memory-intensive. The changes are localized to the test and appear correct.

@mergify mergify bot added the v1 label Jul 30, 2025
Signed-off-by: mgoin <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@DarkLight1337 DarkLight1337 merged commit 055bd39 into vllm-project:main Jul 31, 2025
44 checks passed
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
from vllm.multimodal.utils import encode_image_base64

MODEL_NAME = "Qwen/Qwen2.5-VL-3B-Instruct"
MODEL_NAME = "RedHatAI/Qwen2.5-VL-3B-Instruct-quantized.w4a16"
Copy link
Member

@tlrmchlsmth tlrmchlsmth Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this model also breaks the CI unfortunately:

[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683] ValueError: Failed to find a kernel that can implement the WNA16 linear layer. Reasons:
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683] MacheteLinearKernel requires capability 90, current compute  capability is 89
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683]  AllSparkLinearKernel cannot implement due to: For Ampere GPU, AllSpark does not support group_size = 128. Only group_size = -1 are supported.
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683]  MarlinLinearKernel cannot implement due to: Weight output_size_per_partition = 6840 is not divisible by  min_thread_n = 64. Consider reducing tensor_parallel_size or running with --quantization gptq.
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683]  Dynamic4bitLinearKernel cannot implement due to: Only CPU is supported
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683]  BitBLASLinearKernel cannot implement due to: bitblas is not installed. Please install bitblas by running `pip install bitblas>=0.1.0`
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683]  ConchLinearKernel cannot implement due to: conch-triton-kernels is not installed, please install it via `pip install conch-triton-kernels` and try again!
[2025-08-03T23:44:26Z] (EngineCore_0 pid=14405) ERROR 08-03 16:44:26 [core.py:683]  ExllamaLinearKernel cannot implement due to: Exllama only supports float16 activations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change the device running this test?

vadiklyutiy pushed a commit to CentML/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants