[BugFix] Fix case where collective_rpc returns None
#22006
Conversation
Signed-off-by: Nick Hill <[email protected]>
njhill
requested review from
WoosukKwon,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where collective_rpc would fail when returning None or a list of Nones. The changes correctly handle None values during serialization and deserialization of utility method results. The modifications in vllm/v1/serial_utils.py are sound, and the new tests in tests/v1/engine/test_engine_core_client.py adequately cover the fix. The changes look good and I don't see any issues.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
github-actions
bot
added
the
ready
…#22006) Signed-off-by: Nick Hill <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]>
…#22006) Signed-off-by: Nick Hill <[email protected]>
2 participants
Follow-on from #21845. Returning list of
Nones was not handled properly.