[V0 Deprecation][TPU] Remove V1 flag check from tests #22248
Conversation
mergify
bot
added
documentation
Signed-off-by: NickLucche <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the VLLM_USE_V1 flag check from TPU tests, which is a good cleanup step following the deprecation of the V0 TPU backend. The changes are consistent with the goal of removing V0 support and ensure that tests will now fail explicitly if an unsupported configuration is used, rather than being skipped. The documentation update in google_tpu.md is also a clear improvement. The changes are correct and improve the maintainability of the test suite.
NickLucche
changed the title
|
This one got labelled "docs" by mistake because of some older commits I had around, sorry. |
DarkLight1337
added
ready
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…2248) Signed-off-by: NickLucche <[email protected]> Signed-off-by: zitian.zhao <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…2248) Signed-off-by: NickLucche <[email protected]>
4 participants
There's no TPU V0 backend anymore since #20412.
Let's update tests too.