-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[BugFix] Fix port lookup in internal DP LB tests #22252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nick Hill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a race condition in the multi-node internal load balancer tests by pre-allocating the server list. This ensures that server information is stored in a thread-safe manner at a deterministic index. However, this change introduces a critical bug in the __exit__ methods of both MultinodeInternalLBServerManager and APIOnlyServerManager. The cleanup logic was not updated to handle the new list structure which can contain None values, leading to potential TypeErrors and zombie server processes if a server fails to start. This needs to be fixed to ensure reliable test cleanup.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Nick Hill <[email protected]>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing, let's see if the test passes
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Fix subtle race condition bug where API endpoint port is retrieved from the API server which is assumed to be first server in the list, but might not be depending on which starts first.