Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Aug 5, 2025

Fix subtle race condition bug where API endpoint port is retrieved from the API server which is assumed to be first server in the list, but might not be depending on which starts first.

@njhill njhill added the bug Something isn't working label Aug 5, 2025
@mergify mergify bot added the v1 label Aug 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a race condition in the multi-node internal load balancer tests by pre-allocating the server list. This ensures that server information is stored in a thread-safe manner at a deterministic index. However, this change introduces a critical bug in the __exit__ methods of both MultinodeInternalLBServerManager and APIOnlyServerManager. The cleanup logic was not updated to handle the new list structure which can contain None values, leading to potential TypeErrors and zombie server processes if a server fails to start. This needs to be fixed to ensure reliable test cleanup.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 6, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, let's see if the test passes

@DarkLight1337 DarkLight1337 merged commit ae05a6d into vllm-project:main Aug 15, 2025
19 checks passed
@njhill njhill deleted the fix-dp-test1 branch August 15, 2025 05:49
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants