Skip to content

Conversation

@zifeitong
Copy link
Contributor

@zifeitong zifeitong commented Aug 8, 2025

Fixes gpt-oss models on main with blackwell.

My understanding is that mxfp4+blackwell+torch 2.7 is supported.

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where the torch version check for mxfp4 was overly broad, applying to all GPU architectures instead of just Hopper. The change correctly scopes this check, along with the Triton kernel check, to only apply to Hopper GPUs. This allows using mxfp4 on newer architectures like Blackwell with different torch versions.

My main feedback is to consider adding explicit checks for Blackwell and newer architectures to make the code more robust and prevent potential runtime errors if their specific requirements are not met. I've provided a suggestion to add these checks.

Signed-off-by: Zifei Tong <[email protected]>
@zyongye
Copy link
Member

zyongye commented Aug 9, 2025

Your understanding is correct. Thank you.

@mgoin mgoin enabled auto-merge (squash) August 12, 2025 01:15
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 12, 2025
@mgoin mgoin added this to the v0.10.1 milestone Aug 12, 2025
@mgoin mgoin changed the title Fix torch version check for mxfp4 Fix torch version check for SM100 mxfp4 Aug 12, 2025
@simon-mo simon-mo disabled auto-merge August 12, 2025 19:54
@simon-mo simon-mo merged commit 6534d2f into vllm-project:main Aug 12, 2025
39 of 44 checks passed
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Zifei Tong <[email protected]>
Signed-off-by: mgoin <[email protected]>
Co-authored-by: mgoin <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Zifei Tong <[email protected]>
Signed-off-by: mgoin <[email protected]>
Co-authored-by: mgoin <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants