Skip to content

[Misc] Fix the benchmark's README and improve the error messages for the benchmark's argument checks #22654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025
Merged

[Misc] Fix the benchmark's README and improve the error messages for the benchmark's argument checks #22654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32a4dfa
[Misc] Fix the benchmark's README and improve the error messages for …
tanruixiang Aug 11, 2025
2673e08
Merge branch 'main' into fix_benchmark_error_message_and_guide
tanruixiang Aug 16, 2025
13edf1b
Merge branch 'main' into fix_benchmark_error_message_and_guide
tanruixiang Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions benchmarks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ vllm serve Qwen/Qwen2-VL-7B-Instruct
```bash
vllm bench serve \
--backend openai-chat \
--endpoint-type openai-chat \
--model Qwen/Qwen2-VL-7B-Instruct \
--endpoint /v1/chat/completions \
--dataset-name hf \
Expand Down Expand Up @@ -230,6 +231,7 @@ vllm serve Qwen/Qwen2-VL-7B-Instruct
```bash
vllm bench serve \
--backend openai-chat \
--endpoint-type openai-chat \
--model Qwen/Qwen2-VL-7B-Instruct \
--endpoint /v1/chat/completions \
--dataset-name hf \
Expand All @@ -244,6 +246,7 @@ vllm bench serve \
```bash
vllm bench serve \
--backend openai-chat \
--endpoint-type openai-chat \
--model Qwen/Qwen2-VL-7B-Instruct \
--endpoint /v1/chat/completions \
--dataset-name hf \
Expand Down
5 changes: 3 additions & 2 deletions vllm/benchmarks/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,10 +716,11 @@ def get_samples(args, tokenizer) -> list[SampleRequest]:
"openai-chat",
"openai-audio",
]:
# multi-modal benchmark is only available on OpenAI Chat backend.
# multi-modal benchmark is only available on OpenAI Chat
# endpoint-type.
raise ValueError(
"Multi-modal content is only supported on 'openai-chat' and "
"'openai-audio' backend.")
"'openai-audio' endpoint-type.")
input_requests = dataset_class(
dataset_path=args.dataset_path,
dataset_subset=args.hf_subset,
Expand Down