Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Aug 11, 2025

This PR fixes 2 things:

  • Top level multimodal configs don't have base_model_tp_plan. So we make sure we get it from each sub config in TransformersBase
  • If a model with a TP plan is a sub model, the to plan patterns won't match because there is a missing prefix. We now add this prefix before matching.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor requested a review from Isotr0py August 11, 2025 20:23
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two targeted and important fixes for enabling tensor parallelism in multimodal models using the Transformers backend. The first change correctly retrieves the tensor parallelism plan from the text model's configuration, which is the appropriate location for multimodal architectures. The second change smartly restricts the application of tensor parallelization to only the language model component, which correctly prevents unintended and problematic modifications to the vision tower. Both changes are well-implemented and appear correct. I have no further comments.

@hmellor hmellor added this to the v0.10.1 milestone Aug 12, 2025
@hmellor hmellor enabled auto-merge (squash) August 12, 2025 16:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 12, 2025
@vllm-bot vllm-bot merged commit d0a6301 into vllm-project:main Aug 13, 2025
40 of 48 checks passed
@hmellor hmellor deleted the fix-transformers-backend-tp branch August 13, 2025 06:28
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@hmellor hmellor moved this to Done in Transformers backend Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants