-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix Transformers backend tensor parallel for multimodal models #22673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Transformers backend tensor parallel for multimodal models #22673
Conversation
Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two targeted and important fixes for enabling tensor parallelism in multimodal models using the Transformers backend. The first change correctly retrieves the tensor parallelism plan from the text model's configuration, which is the appropriate location for multimodal architectures. The second change smartly restricts the application of tensor parallelization to only the language model component, which correctly prevents unintended and problematic modifications to the vision tower. Both changes are well-implemented and appear correct. I have no further comments.
Signed-off-by: Harry Mellor <[email protected]>
…project#22673) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…project#22673) Signed-off-by: Harry Mellor <[email protected]>
…project#22673) Signed-off-by: Harry Mellor <[email protected]>
…project#22673) Signed-off-by: Harry Mellor <[email protected]>
…project#22673) Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…project#22673) Signed-off-by: Harry Mellor <[email protected]>
This PR fixes 2 things:
base_model_tp_plan
. So we make sure we get it from each sub config inTransformersBase