-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[Model] Modify the gate implementation of glm4_moe #22832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly modifies the gate implementation in the glm4_moe model. The change from ReplicatedLinear to a standard torch.nn.Linear layer is appropriate, as it aligns with the original Hugging Face Transformers implementation where the gate is not a standard parallelizable linear layer. This resolves the underlying issue, and the related adjustments to the forward pass and documentation are also correct. The changes are well-justified and improve the model's correctness and compatibility.
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
In the transformers implementation, the gate isn't an nn.Linear, so we cannot use ReplicatedLinear.
FIX #22751 (comment) (LoRA related issue)
Test Plan
Test Result
(Optional) Documentation Update