Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Aug 13, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

In the transformers implementation, the gate isn't an nn.Linear, so we cannot use ReplicatedLinear.
FIX #22751 (comment) (LoRA related issue)

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from Isotr0py August 13, 2025 16:20
@jeejeelee jeejeelee requested a review from hmellor as a code owner August 13, 2025 16:20
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Aug 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly modifies the gate implementation in the glm4_moe model. The change from ReplicatedLinear to a standard torch.nn.Linear layer is appropriate, as it aligns with the original Hugging Face Transformers implementation where the gate is not a standard parallelizable linear layer. This resolves the underlying issue, and the related adjustments to the forward pass and documentation are also correct. The changes are well-justified and improve the model's correctness and compatibility.

@Isotr0py Isotr0py enabled auto-merge (squash) August 14, 2025 06:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 14, 2025
@vllm-bot vllm-bot merged commit 92ff41a into vllm-project:main Aug 14, 2025
47 of 53 checks passed
@jeejeelee jeejeelee deleted the fix-glm4-gate branch August 14, 2025 14:29
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants