[Misc] Fix codeowners override for v1 sample and attention #25037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
heheda12345
approved these changes
Sep 17, 2025
Collaborator
heheda12345
left a comment
heheda12345
left a comment
There was a problem hiding this comment.
Yes this fixes my concern in #24928 . Approved but want the affected people to confirm whether you want to own the whole folder or want you + people in /vllm/v1 to maintain the folder together.
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: 22quinn <[email protected]>
github-actions
bot
added
the
ready
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
…ect#25037) Signed-off-by: 22quinn <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: 22quinn <[email protected]> Signed-off-by: yewentao256 <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…ect#25037) Signed-off-by: 22quinn <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…ect#25037) Signed-off-by: 22quinn <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…ect#25037) Signed-off-by: 22quinn <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…ect#25037) Signed-off-by: 22quinn <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…ect#25037) Signed-off-by: 22quinn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Later entry /vllm/v1 would override the earlier entries, as discussed in #24928 and tested in #25034
Also sorting the entries in v1.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.