Skip to content

Conversation

@hl475
Copy link
Contributor

@hl475 hl475 commented Sep 19, 2025

Purpose

With the recent change from #24054 , on ROCM_VERSION >= 60200, we found the AMD build fails with the error msg like

unknown type name '__hip_fp8_e4m3'
   29 | typedef __hip_fp8_e4m3 __nv_fp8_e4m3;
      |         ^

This PR uses the approach from #14245 to utilize the marco HIP_FP8_TYPE_OCP to handle the issue.

Test Plan

CI

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Huamin Li <[email protected]>
@mergify mergify bot added the rocm Related to AMD ROCm label Sep 19, 2025
@houseroad
Copy link
Collaborator

CI probably doens't really run in this case. I remember the internal fix is switching ROCm 6.4.2, shall we use the same solution?

@houseroad houseroad requested review from HAIAI and gshtras September 19, 2025 21:40
@houseroad
Copy link
Collaborator

@HAIAI may share some insights here

@hl475 hl475 closed this Sep 20, 2025
@hl475 hl475 deleted the fix_amd_build branch September 20, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants