[V0 Deprecation] Remove V0-only methods in multi-modal registry #25362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
added
the
ready
DarkLight1337
commented
Sep 22, 2025
| return visual(pixel_values_on_device, | ||
| grid_thw=video_grid_thw_on_device).cpu() | ||
|
|
||
| # V1 Test: this calls a V0 internal. |
There was a problem hiding this comment.
I forgot to remove this in #18465
mergify
bot
added
multi-modality
ywang96
approved these changes
Sep 22, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request focuses on removing dead code by deleting V0-only methods (get_max_tokens_by_modality and get_max_multimodal_tokens) from the MultiModalRegistry. The changes are straightforward and correctly remove the deprecated functionality along with its import. I've identified one area for improvement: the function processor_only_cache_from_config seems to be orphaned by these changes and should also be removed from vllm/multimodal/cache.py to complete the dead code cleanup and avoid future confusion.
Isotr0py
approved these changes
Sep 22, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…-project#25362) Signed-off-by: DarkLight1337 <[email protected]>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…-project#25362) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: charlifu <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: yewentao256 <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…-project#25362) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…-project#25362) Signed-off-by: DarkLight1337 <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…-project#25362) Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove dead code
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.