Add backward compatibility for guided_... API
#25615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harry Mellor <[email protected]>
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds backward compatibility for deprecated guided_* API parameters by re-introducing them and forwarding their values to the new structured_outputs parameter. The changes are mostly correct, but I found a critical issue that would cause a TypeError at runtime due to an incorrect parameter being passed to StructuredOutputsParams. Additionally, there's an inconsistency where structural_tag is not handled for CompletionRequest, which I've also pointed out.
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Cyrus Leung <[email protected]>
Signed-off-by: Cyrus Leung <[email protected]>
DarkLight1337
added
the
ready
aarnphm
approved these changes
Sep 25, 2025
Collaborator
|
Let's also wait 3.9 EOL before merging this PR. |
Member
|
How is that related? |
Collaborator
|
Member
|
No, that has been supported since Python 3.9 (PEP 585) |
Signed-off-by: Harry Mellor <[email protected]>
Zhuul
pushed a commit
to Zhuul/vllm
that referenced
this pull request
Sep 26, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Cyrus Leung <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Cyrus Leung <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: yewentao256 <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Cyrus Leung <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Cyrus Leung <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Cyrus Leung <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Cyrus Leung <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstates backward compatiblility for the following APIs removed by #22772:
CompletionRequestandChatCompletionRequeststructured_outputs