[ROCm][Bugfix] Add missing parameter to ROCm backend #26029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Shtrasberg <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a bugfix that aligns the get_kv_cache_shape method in RocmAttentionBackend with the base class interface by adding the cache_dtype_str parameter. This change is a follow-up to a broader update that was applied to other attention backends. The new parameter is currently unused within the method, which is consistent with other backends where the KV cache shape does not depend on the cache data type. The change is correct and addresses the interface inconsistency.
aarnphm
approved these changes
Oct 1, 2025
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: yewentao256 <[email protected]>
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: Tomer Asida <[email protected]>
southfreebird
pushed a commit
to southfreebird/vllm
that referenced
this pull request
Oct 7, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
) Signed-off-by: Gregory Shtrasberg <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #25896 that skipped ROCm attention backend when adding the new parameter to get_kv_cache_shape