[Bugfix] Fixes prefix-repetition benchmark script #26828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
kouroshHakha
added
the
ready
kouroshHakha
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the prefix-repetition benchmark script where the return value of _generate_exact_length_tokens was not being handled correctly. The function returns both tokens and a mismatch count, but the original code failed to unpack this tuple for prefix tokens, leading to incorrect behavior. This change correctly unpacks the tuple for both prefix and suffix tokens and accumulates the mismatch counts. The fix also corrects a typo in a variable name (token_mistmatch to suffix_mismatch), improving code clarity. The changes are correct and effectively resolve the bug.
ruisearch42
approved these changes
Oct 14, 2025
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: bbartels <[email protected]>
sducouedic
pushed a commit
to sducouedic/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: 0xrushi <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Kourosh Hakhamaneshi <[email protected]> Signed-off-by: 0xrushi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_generate_exact_length_tokensreturns both tokens and mismatch number. The benchmark script has not been update to conform to this change.