[Performance] Optimize encoder cache memory consumption by storing encoder outputs only #26924
+60
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #25903
This PR modifies model runners (they operates encoder cache) & multi modal Placeholder (they provide the metadata) to count and cache the original encoder cache instead of the interleaved encoder cache.
In detail, this PR includes following modifications:
num_embeds
is_embed
to enable more concrete schedulingencoder_output
(instead of the interleaved one currently)encoder_output
by countingTrue
inPlaceholderRange.is_embed
maskRequest.get_num_encoder_tokens
to return actual encoder tokens num (without non embedding tokens) for encoder cache scheduling, coresponding to the modified encoder caching behaviourStill in draft part
is_embed
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.