Skip to content

Conversation

@zhewenl
Copy link
Collaborator

@zhewenl zhewenl commented Oct 27, 2025

Purpose

Fix Model Executor Test running on AMD CI:(example)
We need to skip fastsafetensors tests, since it's only supporting CUDA platform.

Test Plan

CI: https://buildkite.com/vllm/amd-ci/builds/635
Screenshot 2025-10-27 at 5 20 07 PM

pytest -v -s model_executor
...
================================================================== warnings summary ==================================================================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

model_executor/model_loader/tensorizer_loader/test_tensorizer.py:281
  /data/users/zhewenli/gitrepos/vllm-fork/tests/model_executor/model_loader/tensorizer_loader/test_tensorizer.py:281: PytestUnknownMarkWarning: Unknown pytest.mark.flaky - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.flaky(reruns=3)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! KeyboardInterrupt !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
/home/zhewenli/uv_env/vllm-fork/lib64/python3.12/site-packages/urllib3/response.py:429: KeyboardInterrupt
(to show a full traceback on KeyboardInterrupt use --full-trace)
=============================================== 13 passed, 2 skipped, 3 warnings in 1592.21s (0:26:32) ===============================================

@mergify mergify bot added the rocm Related to AMD ROCm label Oct 27, 2025
Signed-off-by: zhewenli <[email protected]>
@zhewenl zhewenl force-pushed the fix-amd-model-executor-test branch from 0f86ed3 to 66ef88e Compare October 27, 2025 22:43
Signed-off-by: zhewenli <[email protected]>
@mergify mergify bot added the ci/build label Oct 27, 2025
@zhewenl zhewenl marked this pull request as ready for review October 28, 2025 00:21
@zhewenl zhewenl added the ci-failure Issue about an unexpected test failure in CI label Oct 28, 2025


@pytest.mark.skipif(
not current_platform.is_cuda(), reason="fastsafetensors requires CUDA/NVIDIA GPUs"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you create issues to keep track of this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking in #27624

@yeqcharlotte yeqcharlotte enabled auto-merge (squash) October 28, 2025 02:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 28, 2025
@yeqcharlotte yeqcharlotte merged commit 0291fbf into vllm-project:main Oct 28, 2025
25 checks passed
ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Nov 7, 2025
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants