Skip to content

[MISC] Remove format.sh #28906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

[MISC] Remove format.sh #28906

merged 1 commit into from
Nov 18, 2025

Conversation

@KuntaiDu
Copy link
Collaborator

@KuntaiDu KuntaiDu commented Nov 18, 2025 •
edited by github-actions bot
Loading

Purpose

As format.sh is deprecated by #16015 for 8 months, now we can safely remove it.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@KuntaiDu
remove format.sh
2a046eb 
Signed-off-by: Kuntai Du <[email protected]>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the format.sh script, which, as noted in the description, has been deprecated for 8 months in favor of pre-commit hooks. This change is a straightforward and appropriate cleanup of an obsolete file. The review did not identify any issues with this removal.

DarkLight1337
DarkLight1337 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 18, 2025 04:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 18, 2025
@DarkLight1337 DarkLight1337 merged commit 5bb1da5 into vllm-project:main Nov 18, 2025
17 checks passed
Victor49152 pushed a commit to Victor49152/vllm that referenced this pull request Nov 20, 2025
@KuntaiDu @Victor49152
[MISC] Remove format.sh (vllm-project#28906)
b49aea7 
Signed-off-by: Kuntai Du <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KuntaiDu @DarkLight1337