usage lib get version another way #3735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkaichao
approved these changes
Mar 29, 2024
njhill
approved these changes
Mar 29, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 31, 2024
njhill
added a commit
to njhill/vllm
that referenced
this pull request
Apr 2, 2024
Using importlib version() function doesn't work in the docker image. Introduced in vllm-project#3634 Equivalent fix to vllm-project#3735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach is compatible with our docker installation.