[Bugfix] Destroy PP groups properly #5265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2024 23:10
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
|
cc: @youkaichao |
youkaichao
approved these changes
Jun 5, 2024
|
Hey @youkaichao test failure looks unrelated - can you comment? |
|
I'm working on #5293 , after that, we don't need separate code for pp and tp anymore. No more copy-pasting. Code will be shared for pp and tp. |
|
Ok, in that case I'll let you decide whether you want to merge this or not. IMO it's relatively safe to merge this in the mean time as it's just a small bugfix, but might not matter either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fix to properly delete PP groups when
destroy_model_parallelis called.