Skip to content

Conversation

@kerthcet
Copy link
Contributor

FILL IN THE PR DESCRIPTION HERE

xref: #4587

@youkaichao I have no env to test with the vGPU+vLLM, but at least we can avoid to warmup when the worldsize = 1, do you agree?

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@youkaichao
Copy link
Member

I agree with the idea, but why this PR touches so many lines?

You just need to avoid the warmup if world size > 1.

@kerthcet
Copy link
Contributor Author

Ok, got your idea about avoid warmup once worldsize is 1, what I did here is slightly different. Will modify as you suggested.

Signed-off-by: kerthcet <[email protected]>
@kerthcet
Copy link
Contributor Author

Done

@youkaichao
Copy link
Member

can you revert the format change? let's keep the pr clean on what is changed.

kerthcet added 2 commits June 12, 2024 15:08
This reverts commit ed4f36b.
Signed-off-by: kerthcet <[email protected]>
@kerthcet kerthcet force-pushed the fix/avoid-to-warmup branch from 5e53a9f to 3fba472 Compare June 12, 2024 07:11
@kerthcet
Copy link
Contributor Author

can you revert the format change? let's keep the pr clean on what is changed.

Make sense to me, I used to make them separate commits. Anyway, reverted.

Signed-off-by: kerthcet <[email protected]>
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments! It can be merged once it passed all the tests.

@kerthcet
Copy link
Contributor Author

Thanks for the quick reply.

@kerthcet
Copy link
Contributor Author

It's weird, the test buildkite/ci/pr pending for several hours, still not finished.

@kerthcet
Copy link
Contributor Author

Seems we totally removed the warmup in #5293, can I know the reason here? @youkaichao

@youkaichao
Copy link
Member

oh, I just happen to remove the warmup because I don't want the warmup for world/tp/pp group. sorry for overwriting your PR!

@kerthcet
Copy link
Contributor Author

Make sense, seems we can close now.

@kerthcet kerthcet closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants