Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

After PR #4645 was merged today, the TPU backend has been broken with the following error:

TypeError: Can't instantiate abstract class TPUExecutor with abstract methods add_prompt_adapter, list_prompt_adapters, pin_prompt_adapter, remove_prompt_adapter

This PR fixes the bug by adding the prompt adapter methods that simply raise NotImplementedError.

@WoosukKwon WoosukKwon added the tpu Related to Google TPUs label Jul 10, 2024
@WoosukKwon WoosukKwon merged commit 5ed3505 into main Jul 10, 2024
@WoosukKwon WoosukKwon deleted the fix-tpu-soft-prompt branch July 10, 2024 02:30
adityagoel14 pushed a commit to adityagoel14/vllm-torchrun-test that referenced this pull request Jul 10, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tpu Related to Google TPUs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant