Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Aug 2, 2024

As vLLM begins to continuously support an increasing number of VL models(See: #4194 (comment)), these models also need to support LoRA(See: #4194 (comment) P2).

The layers currently supporting LoRA may not fully meet the LoRA of VL models. For example, the visual encoder does not use TP , while the LLM uses TP. Therefore, supporting LoRA in ReplicatedLinear will facilitate future VL models support LoRA.

What's more, due to #6961 disable LoRA test, I conducted the relevant tests on my local server, and the results are as follows:

40c029120dd0aa9090f93ae2f1fec130

ping @Yard1
cc @ywang96 @DarkLight1337

@github-actions
Copy link

github-actions bot commented Aug 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@WoosukKwon WoosukKwon merged commit 99d7cab into vllm-project:main Aug 3, 2024
@jeejeelee jeejeelee deleted the replicatedlinear-lora branch August 4, 2024 23:34
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants