Skip to content

Conversation

@kylesayrs
Copy link
Contributor

This PR reverts #7277, specifically commit 373538f.

This addresses an incompatibility between the nvcr.io/nvidia/pytorch:24.05-py3 docker container and compressed-tensors's accelerate dependency. #7277 will be readded once accelerate is moved to an optional dependency in a future compressed-tensors release.

FIX #7516

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@kylesayrs
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 14, 2024
@kylesayrs
Copy link
Contributor Author

Tests are failing because of torch.OutOfMemoryErrors

@mgoin
Copy link
Member

mgoin commented Aug 14, 2024

There are also seemingly tokenizer issues now https://buildkite.com/vllm/ci-aws/builds/6845#01915175-06f3-4ca9-b597-637d6e4dd026/193-731

@kylesayrs
Copy link
Contributor Author

These are failing on main as well as of commit d3d9cb6
https://buildkite.com/vllm/ci-aws/builds/6826#01914fe8-fa2b-4c9a-ab41-7945e2ae82dd

@simon-mo simon-mo merged commit f55a9ae into vllm-project:main Aug 14, 2024
@kylesayrs kylesayrs deleted the revert-compressed-tensors-reuse branch August 17, 2024 00:35
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ImportError related to compressed tensors module

3 participants