Skip to content

[Bugfix] Fix default weight loading for scalars #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2024
Merged

[Bugfix] Fix default weight loading for scalars #7534

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c247983
Fix default weight loading for scalars
mgoin Aug 14, 2024
43cb06b
Update comment
mgoin Aug 14, 2024
9182f3d
Format
mgoin Aug 14, 2024
16c1b63
Merge branch 'main' into fix-scalar-loading
mgoin Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions vllm/model_executor/model_loader/weight_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,11 +516,17 @@ def default_weight_loader(param: torch.Tensor,
loaded_weight: torch.Tensor) -> None:
"""Default weight loader."""
try:
assert param.size() == loaded_weight.size(), (
f"Attempted to load weight ({loaded_weight.size()}) "
f"into parameter ({param.size()})")

param.data.copy_(loaded_weight)
if param.numel() == 1 and loaded_weight.numel() == 1:
# Sometimes scalar values aren't considered tensors with shapes
# so if both param and loaded_weight are a scalar,
# "broadcast" instead of copy
param.data.fill_(loaded_weight.item())
else:
assert param.size() == loaded_weight.size(), (
f"Attempted to load weight ({loaded_weight.size()}) "
f"into parameter ({param.size()})")

param.data.copy_(loaded_weight)
except Exception:
# NOTE: This exception is added for the purpose of setting breakpoint to
# debug weight loading issues.
Expand Down