Skip to content

[MISC] Skip dumping inputs when unpicklable #8744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
+9 −1
Merged

[MISC] Skip dumping inputs when unpicklable #8744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c560867
Skip dumping inputs when unpicklable
comaniac Sep 23, 2024
869200f
Skip dumping inputs when unpicklable
comaniac Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion vllm/worker/model_runner_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,15 @@ def _wrapper(*args, **kwargs):
for t in kv_caches
if is_tensor(t)]

pickle.dump(dumped_inputs, filep)
try:
pickle.dump(dumped_inputs, filep)
except Exception as pickle_err:
logger.warning(
"Failed to pickle inputs of failed execution: %s",
str(pickle_err))
raise type(err)(f"Error in model execution: "
f"{str(err)}") from err

logger.info(
"Completed writing input of failed execution to %s.",
filename)
Expand Down
Loading