Skip to content

Conversation

yudian0504
Copy link
Contributor

@yudian0504 yudian0504 commented Oct 21, 2024

This PR fixes a bug introduced by #8645.

related issues: #9448 & #9417 & #9409

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yudian0504 yudian0504 changed the title [Bugfix][Msic]: fix graph capture for decoder [Bugfix][Misc]: fix graph capture for decoder Oct 21, 2024
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the unblock. Meanwhile, I'm not sure how encoder-decoder works in this case. @varun-sundar-rabindranath PTAL. Also cc @sroy745

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 21, 2024
Copy link
Contributor

@varun-sundar-rabindranath varun-sundar-rabindranath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake !! Thanks for the fix @yudian0504 🙌

@comaniac comaniac enabled auto-merge (squash) October 21, 2024 16:18
@jeejeelee
Copy link
Collaborator

Good catch, this solved a bug I encountered.

@comaniac comaniac merged commit 8ca8954 into vllm-project:main Oct 21, 2024
70 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@xfalcox
Copy link

xfalcox commented Oct 31, 2024

This bug fix is so important, we need a release for the new docker image cc @DarkLight1337

@DarkLight1337
Copy link
Member

DarkLight1337 commented Oct 31, 2024

This bug fix is so important, we need a release for the new docker image cc @DarkLight1337

For now, you can use the Docker image here with the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants