Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Nov 1, 2024

Allows us to support quantization of the vision encoder for PixtralHF, where before we could only quantize the language model. Also converts the raw torch nn.Linear modules to proper merged vLLM Linear modules

Tested with

  • neuralmagic/pixtral-12b-FP8-dynamic (only MistralModel quantized)
  • nm-testing/pixtral-12b-FP8-dynamic-all (MistralModel and PixtralHFTransformer quantized, just not lm_head)

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 1, 2024
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not related to this PR in particular but does it make sense to use get_act_and_mul_fn and act_and_mul everywhere?

@ywang96 ywang96 merged commit a53046b into vllm-project:main Nov 5, 2024
60 checks passed
@mgoin
Copy link
Member Author

mgoin commented Nov 5, 2024

Yeah this was my thinking @ywang96, with get_act_and_mul_fn now we should be able to replace most hardcoded SiluAndMul usages. First I'm going to look to see if we need this ScaledActivation case anymore

JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants