Fix add_custom_command OUTPUT paths #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OUTPUTargument inadd_custom_commandcan accept several variables with filenames or a single list variable with several filenames. But since two lists were passed there (SOURCES_FILE_LISTandHEADERS_FILE_LIST), each of them was counted as single file path. This caused the bindings to be recompiled after every CMake reconfiguration (because path was wrong).In this PR I fixed it by using a single command to obtain headers and source files into
GENERATED_FILES_LIST(there is no sense to separate them).