Skip to content

Conversation

@BastiaanOlij
Copy link
Collaborator

Godot will convert all floats it returns, and expects all floats we sent to it as parameters to be doubles. It will convert them between float and double as needed before interacting with the extension.

I guess this is to make the API more resilient once we start building godot with real_t_as_double even though it doesn't solve structs and classes using float where we want direct access to members and need correct typing.

Also I'm not sure what the benefit is of letting us know the original datatype is float if we're not exposing that so there is an argument that this is not the correct fix but that instead meta should always be set to double in the json.

@BastiaanOlij BastiaanOlij changed the base branch from master to gdnative-extensions September 4, 2021 11:42
@vnen vnen merged commit 226d09f into vnen:gdnative-extensions Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants