OverflowMenu wrong onPress callback called

[mmaass]

Hi,

i have two HiddenItems in an OverflowMenu. The 1st item is disabled. When i click on the second item, the onPress callback of the first (disabled one) gets called.

I've captured a video of the bug.

bug.mp4

Or am I doing something wrong here? I've also tried not to define the onPress prop on the first item, but this causes an error as well. (which is at least consistent with the aforementioned bug)

The version is 7.0.1

[vonovak]

hello, please find

react-navigation-header-buttons/src/overflowMenuPressHandlers.js

Line 89 in 2fca2fd

hiddenButtons[buttonIndex - 1].onPress();

and change

hiddenButtons[buttonIndex - 1].onPress();

to

enabledButtons[buttonIndex - 1].onPress();

and let me know if it works, thanks!

[mmaass]

Yes, that fixes the problem.

[vonovak]

that bug managed to live there for a pretty long time... thanks for reporting!

[mmaass]

thanks for fixing