Skip to content

Suggestions for #6343 #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: nikhil/6343-adjudication-state-hook
Choose a base branch
from
Open

Suggestions for #6343 #6816

wants to merge 2 commits into from

Conversation

eventualbuddha
Copy link
Contributor

Some suggested changes for #6343:

  • Small style warning fixes.
  • Use Map instead of Record to make the types a bit stricter and make this new code less susceptible to failing with option IDs like toString.

@eventualbuddha eventualbuddha requested a review from nikhilb4a July 21, 2025 15:32
@eventualbuddha eventualbuddha changed the base branch from main to nikhil/6343-adjudication-state-hook July 21, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilb4a nikhilb4a Awaiting requested review from nikhilb4a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eventualbuddha