feat(build): honor custom component name for single file wc builds #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you avoid auto-reformatting in the PR? It makes it difficult to review the actual changes. |
|
sorry about that. I just disabled the format on save setting in vscode so hopefully this doesn't happen in future PRs 🤞 |
…ixes vuejs#1146) Fixes issue that prevented single entry wc builds from honoring the `--name` argument. The build process would just use the entry file name for the component name when registering the component previously
dhensche
force-pushed
the
honor-custom-wc-name
branch
from
e6b313d to
b471f3b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1146
Fixes issue that prevented single entry wc builds from honoring the
--nameargument.The build process would just use the entry file name for the component name when registering the component previously