Skip to content

fix(vdom): svg inside foreignObject should be rendered with correct namespace (fix #7330) #7350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2018
Merged

fix(vdom): svg inside foreignObject should be rendered with correct namespace (fix #7330) #7350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b23f5ff
add failed test case
javoski Dec 31, 2017
7769c73
fix failed test case
javoski Dec 31, 2017
98db471
fix(vdom): svg inside foreignObject should be rendered with correct n…
javoski Dec 31, 2017
725cc1b
adjust comments
javoski Dec 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/vdom/create-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ function applyNS (vnode, ns, force) {
if (isDef(vnode.children)) {
for (let i = 0, l = vnode.children.length; i < l; i++) {
const child = vnode.children[i]
if (isDef(child.tag) && (isUndef(child.ns) || isTrue(force))) {
if (isDef(child.tag) && (
isUndef(child.ns) || (isTrue(force) && child.tag !== 'svg'))) {
applyNS(child, ns, force)
}
}
Expand Down
4 changes: 3 additions & 1 deletion test/unit/modules/vdom/create-element.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,12 @@ describe('create-element', () => {
it('render svg foreignObject with correct namespace', () => {
const vm = new Vue({})
const h = vm.$createElement
const vnode = h('svg', [h('foreignObject', [h('p')])])
const vnode = h('svg', [h('foreignObject', [h('p'), h('svg')])])
expect(vnode.ns).toBe('svg')
expect(vnode.children[0].ns).toBe('svg')
expect(vnode.children[0].children[0].ns).toBeUndefined()
// #7330
expect(vnode.children[0].children[1].ns).toBe('svg')
})

// #6642
Expand Down