feat($theme): Add search box placeholder setting to theme-config #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozero
added
complexity: easy
flozero
added
topic: theme
|
hello @boaz0 do we have any tests for it ? |
|
@f3ltron nope, would you mind giving me a hint how I can test that? |
|
That was just a suggestion ^^. I will have a look about it before review. Thank's for your work @boaz0 ! |
flozero
approved these changes
Sep 7, 2019
kefranabg
requested changes
Sep 10, 2019
packages/@vuepress/theme-default/components/AlgoliaSearchBox.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Boaz Shuster <[email protected]>
|
Thanks @kefranabg for your feedback. Updated the PR. Feel free to review again. 🙏 |
kefranabg
changed the title
|
Thanks again! 💚 |
|
Thank you all @f3ltron & @kefranabg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add search-box placeholder option to the config file
closes #1650
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: