Skip to content

Refactored Test plan for The Disclosure of Answers to Frequently Asked Questions Example #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Apr 25, 2025

Preview Tests

Test Plan Updates:

  • Update Tests 2 & 4: Modified Tests 2 and 4 to include interaction with the fourth disclosure button, aligning them with the testing approach used in the Disclosure Navigation example test plan for consistency.
  • Add setupScripts: Introduced setupScripts to programmatically focus and expand the fourth disclosure button.
  • Add New Assertions:
    • Included a new assertion to convey the description list (dl) boundary.
    • Added an assertion to confirm that the name of the fourth disclosure button is conveyed.
  • Update Screen Reader Commands: Updated JAWS, NVDA, and VoiceOver commands to reflect the modified test scope.

@IsaDC IsaDC self-assigned this Apr 25, 2025
@IsaDC IsaDC marked this pull request as ready for review April 25, 2025 17:59
@IsaDC IsaDC requested a review from mcking65 April 25, 2025 18:00
@IsaDC IsaDC requested a review from jscholes April 25, 2025 18:00
mcking65 added 4 commits May 4, 2025 15:31
Made the assertion: "List boundary is conveyed".

The description list boundary is technically more correct. However, the ARIA mapping is actually "association list" and every screen reader is handling this differently. There has been discussion in ARIA about this mapping. No one seems to be happy with it.

I am not confident it would be a good idea to fail screen readers that simply call it a list. That is what NVDA and Narrator do. JAWS still calls it a "definition list". VoiceOver calls it a description list.

Open to further discussion about this change.
* Change button reference to htmlAam type.
* Added a dd reference
* Added references to assertions.
For consistency with prior plans and editorial guidelines, changed parentheses to single quotes so assertions of the form:

>Change in state (to expanded) is conveyed

are now:

>Change in state to 'expanded' is conveyed
@mcking65
Copy link
Contributor

mcking65 commented May 5, 2025

@IsaDC

Somehow there are 4859 files changed by this pull request. I think you might have committed a temp working directory or something like that. I can't get the files tab of this PR to function with that many files changed.

@mcking65
Copy link
Contributor

mcking65 commented May 5, 2025

@IsaDC

I pushed commits with the following changes ...

Changed 'DescriptionListBoundary' to "listBoundary'

Made the assertion: "List boundary is conveyed".

The description list boundary is technically more correct. However, the ARIA mapping is actually "association list" and every screen reader is handling this differently. There has been discussion in ARIA about this mapping. No one seems to be happy with it.

I am not confident it would be a good idea to fail screen readers that simply call it a list. That is what NVDA and Narrator do. JAWS still calls it a "definition list". VoiceOver calls it a description list.

Open to further discussion about this change.

Updated references

  • Change button reference to htmlAam type.
  • Added a dd reference
  • Added references to assertions.

Editorial changes to state assertions

For consistency with prior plans and editorial guidelines, changed parentheses to single quotes so assertions of the form:

Change in state (to expanded) is conveyed

are now:

Change in state to 'expanded' is conveyed

@IsaDC
Copy link
Contributor Author

IsaDC commented May 5, 2025

Thank you @mcking65
We can discuss all of this in today's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants