Define CanMakePaymentEvent.respondWith() behavior #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsolomakhin
requested changes
Apr 16, 2018
| instance. | ||
| </li> | ||
| <li>If <var>event</var>'s <a>isTrusted</a> attribute is false, then | ||
| <a>throw</a> an "<a>InvalidStateError</a>" <a>DOMException</a>. |
There was a problem hiding this comment.
Is this the right error type?
There was a problem hiding this comment.
I believe this is right. You may be confused with deprecated InvalidAccessError.
Am I missing something?
rsolomakhin
reviewed
Apr 16, 2018
There was a problem hiding this comment.
@marcoscaceres : Please take a look. I believe you have expertise here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #295 (partially)
The following tasks have been completed:
Implementation commitment:
Preview | Diff