-
Notifications
You must be signed in to change notification settings - Fork 328
Update Understanding "focus visible" (SC 2.4.7) #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JAWS-test2
wants to merge
3
commits into
w3c:main
Choose a base branch
from
JAWS-test2:SC2.4.7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the user supposed to work when the focus is not shown initially? How does a screen reader user perceive what happened to the focus?
If the focus is not visible initially, the user doesn't see where the focus is and might initiate an action that is not wanted. Also, having to interact to see the focus reduces efficiency considerable and distracts from the task all the time.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I agree with this addition (and btw, there's a typo in "initially"):
There is a difference between a page that does not have an element in focus initially, and one where there is a focusable element that is not properly shown as active. I don't think this nuance is clear, nor how to address in respect to Focus Visible. I'm also not sure that the number of focusable controls on the screen is relevant to that.
I do not think this PR sufficiently captures or addresses the initial question in #1001.
I think these are good questions to provide guidance on:
I think more detail is required, and I don't think this PR is sufficient as written. I'm okay to keep the scope of this change contained, but I think it should clearly answer at least one of the questions that seems to exist in #1001 discussion.