Removing incorrect statement related to IP leaking issue. #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incorrect statement is "Applications can avoid exposing IP addresses... by not signalling non-relay ICE candidates." However, simply not signaling candidates is not enough to prevent IP addresses from leaking. These candidates will still be gathered and used to form candidate pairs, which means connectivity checks will be sent leaking the server reflexive address for every network interface.
|
LGTM. |
|
@dontcallmedom This tiny PR is failing due to a failure in travis-ci due to yarn not being installed: |
|
@aboba indeed, that's due to a recent change in respec :( I suggest ignoring Travis CI errors while we figure this out @vivienlacourba could you look into this? I think the best option at this point is to force our CI infrastructure to the last version of ReSpec not using yarn (until travis-ci/apt-source-safelist#322 gets deployed) |
|
@aboba @dontcallmedom this issue has been fixed in #935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect statement is "Applications can avoid exposing IP
addresses... by not signalling non-relay ICE candidates."
However, simply not signaling candidates is not enough to prevent IP
addresses from leaking. These candidates will still be gathered and used
to form candidate pairs, which means connectivity checks will be sent
leaking the server reflexive address for every network interface.