Skip to content

Conversation

SaberDoTcodeR
Copy link

This PSP is related to our implementation of the SubsCrypt Project. This standard can be used in any token contract that supports built-in subscription methods.

@lamafab
Copy link
Contributor

lamafab commented Feb 16, 2022

Hi @SaberDoTcodeR, thanks for the PR.

  • It might be useful to specify the exact types of the parameters (reference).
  • There should probably be a more enhanced description about the concept of a "provider": in the Auth section you mentioned a "token" that should be used when hashing the password. I assume this is related to a identifier of a provider?
  • In the table, it would be convenient to indicate which function is used by the user and which one is used by the provider.

@lamafab lamafab added the awaiting-changes Waiting for upstream changes label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-changes Waiting for upstream changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants