Give testrunner macOS-support #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS does not include the argp library at default. It may be installed via homebrew and needs to be linked to the build.
syscall(SYS_gettid) is not supported on macOS. To mitigate this instead use pthread_self() to get an id for the current thread. While not unique globally, it's unique within the same process which should serve the purposes here sufficiently.
Self-assignment cause warnings in clang. Use void cast instead, once again silencing the warnigns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things are missing in macOS to run test runner properly. Deal with them. Use pthread for thread-id instead of syscall. Add libargp as an explicit library when building under Darwin due to it not being part of the standard lib on macOS. Also address som compiler warnings running with apple clang.