v6: Assertions #471
Merged
v6: Assertions #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Assertions should enforce invariants, not signal error conditions. Unlike Exceptions, AssertionErrors are not caught by catch (Exception e) and may be more unpredictable. We should try to only ever use assertions for cases that can never happen unless there's been a programming mistake on our side. Everything else, e.g. server responses, network errors, client's input (ORM) should be dealt with via exceptions.
bevzzz
force-pushed
the
v6-assertions
branch
from
b238c5e to
b47fd71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertions should enforce invariants, not signal error conditions. Unlike Exceptions, AssertionErrors are not caught by catch (Exception e) and may be more unpredictable.
We should try to only ever use assertions for cases that can never happen unless there's been a programming mistake on our side.
Everything else, e.g. server responses, network errors, client's input (ORM) should be dealt with via exceptions.