Add restore for users and roles #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  1  3  3 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Controller creating containers without dropped capabilities | ...r-compose-backup.yml | View in code |
|
Container Traffic Not Bound To Host Interface | ...r-compose-backup.yml | View in code |
|
Cpus Not Limited | ...r-compose-backup.yml | View in code |
|
Memory Not Limited | ...r-compose-backup.yml | View in code |
|
Healthcheck Not Set | ...r-compose-backup.yml | View in code |
|
Restart Policy On Failure Not Set To 5 | ...r-compose-backup.yml | View in code |
|
Ensure that, if applicable, SELinux security options are set (Automated) | ...r-compose-backup.yml | View in code |
g-despot
reviewed
Jul 14, 2025
weaviate/backup/async_.pyi
Outdated
| include_collections: Union[List[str], str, None] = None, | ||
| exclude_collections: Union[List[str], str, None] = None, | ||
| roles_restore: Optional[Literal["noRestore", "all"]] = None, | ||
| user_restore: Optional[Literal["noRestore", "all"]] = None, |
There was a problem hiding this comment.
I would suggest users_restore to be consistent with roles_restore
This was referenced Jul 14, 2025
tsmith023
approved these changes
Jul 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
- Coverage 87.92% 87.11% -0.81%
==========================================
Files 256 269 +13
Lines 17812 18701 +889
==========================================
+ Hits 15661 16292 +631
- Misses 2151 2409 +258 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.