Skip to content

Fix expired test certificate in AuthTokenSignatureTest #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Fix expired test certificate in AuthTokenSignatureTest #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/test/java/eu/webeid/security/validator/AuthTokenSignatureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,16 @@
import eu.webeid.security.exceptions.AuthTokenSignatureValidationException;
import eu.webeid.security.testutil.AbstractTestWithValidator;
import eu.webeid.security.testutil.AuthTokenValidators;
import eu.webeid.security.util.DateAndTime;
import org.junit.jupiter.api.Test;

import java.security.cert.X509Certificate;

import static eu.webeid.security.testutil.DateMocker.mockDate;
import static eu.webeid.security.util.Strings.toTitleCase;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.Mockito.mockStatic;

class AuthTokenSignatureTest extends AbstractTestWithValidator {

Expand Down Expand Up @@ -77,11 +80,15 @@ void whenValidTokenAndWrongOrigin_thenValidationFails() throws Exception {

@Test
void whenTokenWithWrongCert_thenValidationFails() throws Exception {
final AuthTokenValidator authTokenValidator = AuthTokenValidators.getAuthTokenValidator();
final WebEidAuthToken authTokenWithWrongCert = authTokenValidator.parse(AUTH_TOKEN_WRONG_CERT);
assertThatThrownBy(() -> authTokenValidator
.validate(authTokenWithWrongCert, VALID_CHALLENGE_NONCE))
.isInstanceOf(AuthTokenSignatureValidationException.class);
// Ensure that the certificate does not expire.
try (final var mockedClock = mockStatic(DateAndTime.DefaultClock.class)) {
mockDate("2024-08-01", mockedClock);
final AuthTokenValidator authTokenValidator = AuthTokenValidators.getAuthTokenValidator();
final WebEidAuthToken authTokenWithWrongCert = authTokenValidator.parse(AUTH_TOKEN_WRONG_CERT);
assertThatThrownBy(() -> authTokenValidator
.validate(authTokenWithWrongCert, VALID_CHALLENGE_NONCE))
.isInstanceOf(AuthTokenSignatureValidationException.class);
}
}

}
Loading