New EyeDropper feature #1179
Merged
New EyeDropper feature #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
foolip
reviewed
Jun 3, 2024
Collaborator
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I'm not sure if I should suggest eye-dropped instead of eyedropper. The spec strangely says EyeDropper instead of Eyedropper. But https://helpx.adobe.com/photoshop/using/tool-techniques/eyedropper-tool.html suggests that web developers might be more familiar with "Eyedropper" than "Eye dropper".
ddbeck
reviewed
Jun 3, 2024
ddbeck
approved these changes
Jun 4, 2024
Collaborator
There was a problem hiding this comment.
Thank you @captainbrosset! The test failure here is due to #1182, so this can now merge failing tests notwithstanding cannot merge due to our branch protection rules. The other PR needs to land first. 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.