Fix throwing non-new Errors and literals #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
commented
Jul 9, 2024
Collaborator
Author
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Self-review to highlight relevant bits.
Comment on lines
20
to
33
| "dist": "tsx scripts/dist.ts", | ||
| "schema-defs": "ts-json-schema-generator --tsconfig ./tsconfig.json --type FeatureData --path ./types.ts --id defs", | ||
| "feature-init": "tsx scripts/feature-init.ts", | ||
| "format": "npx prettier --write .", | ||
| "schema-defs:write": "npm run schema-defs -- --out ./schemas/defs.schema.json", | ||
| "test": "npm run test:caniuse -- --quiet && npm run test:schema && npm run test:specs && npm run test:format && npm run test:dist && npm run test --workspaces", | ||
| "schema-defs": "ts-json-schema-generator --tsconfig ./tsconfig.json --type FeatureData --path ./types.ts --id defs", | ||
| "test:caniuse": "tsx scripts/caniuse.ts", | ||
| "test:coverage": "npm run --workspaces test:coverage", | ||
| "test:dist": "tsx scripts/dist.ts --check", | ||
| "test:format": "prettier --check .", | ||
| "test:lint": "npx eslint .", | ||
| "test:schema": "tsx scripts/schema.ts", | ||
| "test:specs": "tsx scripts/specs.ts", | ||
| "test:format": "prettier --check .", | ||
| "test:coverage": "npm run --workspaces test:coverage", | ||
| "format": "npx prettier --write .", | ||
| "feature-init": "tsx scripts/feature-init.ts", | ||
| "test": "npm run test:caniuse -- --quiet && npm run test:schema && npm run test:specs && npm run test:format && npm run test:dist && npm run test --workspaces && npm run test:lint", | ||
| "update-drafts": "tsx scripts/update-drafts.ts" |
Collaborator
Author
There was a problem hiding this comment.
I sorted these, sorry for the chaos diff.
| "test:coverage": "npm run --workspaces test:coverage", | ||
| "test:dist": "tsx scripts/dist.ts --check", | ||
| "test:format": "prettier --check .", | ||
| "test:lint": "npx eslint .", |
| "test:coverage": "npm run --workspaces test:coverage", | ||
| "format": "npx prettier --write .", | ||
| "feature-init": "tsx scripts/feature-init.ts", | ||
| "test": "npm run test:caniuse -- --quiet && npm run test:schema && npm run test:specs && npm run test:format && npm run test:dist && npm run test --workspaces && npm run test:lint", |
| constructor(id: string, featureData: unknown) { | ||
| if (!isFeatureData(featureData)) { | ||
| throw `${id} is not valid feature`; | ||
| throw new Error(`${id} is not valid feature`); |
Collaborator
Author
There was a problem hiding this comment.
Previously thrown as a string, not an error
foolip
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #1312. From #1312 (comment)
Note to self: after merge, rebase and run
npm run test:lint -- --fix.