Update spec drafts #1391
Merged
Update spec drafts #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This was to test if merging a bunch of PRs and then updating drafts would produce a sensible result. And it does. One case that isn't handled yet but hasn't happened here is if all keys in a spec are claimed. Those files should be deleted, but aren't. |
ddbeck
approved these changes
Jul 15, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Extremely satisfying! Let me know if you want a re-review if you tend to deal with the not-deleted file case, otherwise please merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.