-
Notifications
You must be signed in to change notification settings - Fork 201
Add .nvmrc file to specify node version #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Huh, does nvm support (I'll see if asdf could use .nvmrc too.) |
|
Interesting - I don't use asdf, and am not familiar with it. But, it doesn't look like it does. :( |
.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| 22 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I couldn't find a way to consolidate on a single file. How about we just set this to be consistent with .node-version and be done with it?
| 22 | |
| 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running it with 18.16.1 and get an error that I don't get with 22.4.1. @tropicadri mentioned she was having problems with 18 as well and that 22 worked for her. I'm OK with going with 18, but we'll need to specify a subversion as well.
Which version are you running?
file:///Users/petele/Sites/web-features/packages/compute-baseline/dist/browser-compat-data/compat.js:1
import bcd from "@mdn/browser-compat-data" with { type: "json" };
^^^^
SyntaxError: Unexpected token 'with'
at ESMLoader.moduleStrategy (node:internal/modules/esm/translators:119:18)
at ESMLoader.moduleProvider (node:internal/modules/esm/loader:468:14)
Node.js v18.16.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ha. It needs to be >=18.20, which is when import attributes landed in Node.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - changed it to the official Hydrogen build
Quickly select the right version of node when using
nvmfor the repo.